fix: Allow block time offset to be negative #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd26e31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Xanewok
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
Xanewok
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
|
Yes, for bugs we always add a regression test, ideally on the EDR side, using typed method invocations. The integration test folder of the provider already has a bunch of examples. https://github.com/NomicFoundation/edr/tree/main/crates%2Fedr_provider%2Ftests%2Fissues |
Xanewok
had a problem deploying
to
github-action-benchmark
GitHub Actions
Failure
|
Pushed a fix and added a regression test for this; verifying that the test fails without the fix and succeeds afterwards, so this should be ready for review now. |
Xanewok
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Wodann
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #588
This uses a simple approach of first converting to
i128, which we know will be lossless, to only then fallibly convert it to a smaller type ofi64.We do that for simplicity: one could convert a tuple of (sign, value) to shave some bytes and cycles but we would have to explicitly handle the case of
i64::MIN(its absolute value is greater by 1 than i64::MAX), which would be a bit noisy, whereas not handling it and naively using aif sign { -1 } else { 1 } * i64::try_from(value)...would not fully handle that edge case.I tested locally the reproduction steps from #588 and can both confirm that the error happens using the steps and the problem disappears after applying the fix here. Let me know if you feel that we should add a regression test and if so, how would you prefer to proceed with testing this.